-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] 메모 관련 기능 #357
Merged
Merged
[FEAT] 메모 관련 기능 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
find by id and member id
delete by id and member id
thguss
reviewed
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
commit/branch 컨벤션 변경
아 이거 소프티 쉬다가 해서 직전 컨벤션이 적용된 것 같은데..🥹
commit은 컨벤션 최대한 잘 지켜보고, branch는 이름 자체는 잘 안보긴 해서, 알잘깔딱센 할까요?
논의 후 필요하면 추후 칼럼 추가
넵!!
src/main/java/com/soptie/server/api/controller/dto/request/memo/CreateMemoRequest.java
Outdated
Show resolved
Hide resolved
src/main/java/com/soptie/server/api/controller/dto/response/memo/CreateMemoResponse.java
Outdated
Show resolved
Hide resolved
src/main/java/com/soptie/server/domain/membermission/MemberMissionService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/soptie/server/persistence/adapter/MemoAdapter.java
Outdated
Show resolved
Hide resolved
src/main/java/com/soptie/server/persistence/adapter/MemoAdapter.java
Outdated
Show resolved
Hide resolved
thguss
approved these changes
Nov 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ Related Issue
📝 기능 구현 명세
🐥 추가적인 언급 사항