Avoid crashes caused by ME conduits #567
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a quick change to prevent crashes, and should probably be undone if/when the conduit interface changes.
Fixes #505
Fixes #530
Fixes #560
Steps to reproduce the crash this commit fixes:
/tp 5000 200 0
/tp 0 200 0
/tp 5000 200 0
The issue seems to be that conduits objects are reused after
onRemoved
is called, changing that should also fix the crash.Checklist: