Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graph-related fixes #922

Draft
wants to merge 4 commits into
base: dev/1.21.1
Choose a base branch
from
Draft

Graph-related fixes #922

wants to merge 4 commits into from

Conversation

Rover656
Copy link
Member

@Rover656 Rover656 commented Dec 13, 2024 •
edited
Loading

Description

Fixes:

The idle TPS hit was due to our network syncing, while these changes mitigate the impact to a reasonable point, our networking solution still needs some love. I'll begin work on something that will fix these problems.

TODO

Breaking Changes

No breaking changes, pre-existing cap banks and solar panels will keep their stored energy.

Checklist

  • My code follows the style guidelines of this project (.editorconfig, most IDEs will use this for you).
  • I have made corresponding changes to the documentation.
  • My changes are ready for review from a contributor.

@Rover656
fix: Fix conduit duplication using local build of graphlib
e004489 
To be finalised, changes still requested on the graphlib modifications.
@Rover656
feat: Rewrite capacitor backend for more performance
41e7598 
Still need to re-add input/output monitoring.

Also still suffering from significant performance deficit due to network data sync.
It's time for us to look at networking again, but more seriously.
@Rover656
fix: High idle TPS hit of capacitor banks
09e250d 
We were syncing the positions of graph members over the network which was expensive to compute whether it has changed or not.
Because the graph was already local, I've shaved off some of the unnecessary graph logic on the client and use this locally instead.

This may not be the permanent solution, but is good enough to remove the immediate problem.
@Rover656 Rover656 added Type-Bug There is a problem. Area-Backend Backend work not usually visible to players. MC-1.21.1 labels Dec 13, 2024
This was linked to issues Dec 13, 2024
Energy is duplicated when separating energy conduit graphs #920
Open
Capacitor Banks causing lag when connected in large groups #905
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area-Backend Backend work not usually visible to players. MC-1.21.1 Type-Bug There is a problem.
Projects
None yet
Milestone
No milestone
1 participant
@Rover656