Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capacitor Banks causing lag when connected in large groups #905

Open
1 task done
Xefyr0 opened this issue Dec 4, 2024 · 1 comment · May be fixed by #922
Open
1 task done

Capacitor Banks causing lag when connected in large groups #905

Xefyr0 opened this issue Dec 4, 2024 · 1 comment · May be fixed by #922
Labels
Area-Backend Backend work not usually visible to players. MC-1.20.1 MC-1.21.1 P-0-High High priority, crash/breaking. Type-Bug There is a problem.

Comments

@Xefyr0
Copy link

Xefyr0 commented Dec 4, 2024

Is there an existing issue for this?

  • I did not find any existing issues.

Current Behavior

Miliseconds Per Tick (mpst) in empty void dimension: 2-3
mspt with 1x1x1 capacitor bank cube: 2-3
mspt with 2x2x2 capacitor bank cube: 2-3
mspt with 3x3x3 capacitor bank cube: 3-4
mspt with 4x4x4 capacitor bank cube: 2-4
mspt with 5x5x5 capacitor bank cube: 4-5
mspt with 6x6x6 capacitor bank cube: 5-8
mspt with 7x7x7 capacitor bank cube: 8-10
mspt with 8x8x8 capacitor bank cube: 20-26
mspt with 9x9x9 capacitor bank cube: 37-41
mspt with 10x10x10 capacitor bank cube: 102-144

Graphical glitches occured while building the 9x9x9 (Capacitor banks being culled before they were rendered)
My computer fan kicked in shortly after.

It only takes 1000 Capacitor banks sitting in the void dim, doing nothing to drop my TPS below 20. My computer is a good laptop, but this shouldn't be an issue.

For reference: I used Basic Capacitor banks to build the cube.
Image

Expected Behavior

No response

How to Test

  1. Create a new instance with EnderIO and Just Another Void Dimension (JAVD)
  2. Create & enter a new creative world.
  3. Teleport to the void dim with /execute in javd:void tp @p ~ ~ ~
  4. use /setblock ~ ~ ~ minecraft:dirt to get a block to build off of.
  5. Open F3 to see your Miliseconds Per Tick metric. (mspt)
  6. Place down a lot of Capacitor Banks in a single connected blob.
  7. Notice the mspt metric increase.

Local Environment

- **Operating System**: Windows 10 22H2
- **Java version**: Java(TM) SE Runtime Environment (build 17.0.12+8-LTS-286)
- **Minecraft Version**: 1.20.1
- **Version**: 6.2.2-beta
- **Other Mods**: Just Another Void Dimension
- **Computer**: Lenovo ThinkPad X1 Extreme Gen 3

Any Additional Information?

Noted in #857, but never acted upon despite the issue being marked as "resolved".
Would presumably be fixed with #704.

@Xefyr0 Xefyr0 added Status-Triage A Triage Member should take a look at this Type-Bug There is a problem. labels Dec 4, 2024
@github-project-automation github-project-automation bot moved this to To triage in Ender IO Bugs Dec 4, 2024
@Rover656 Rover656 added Area-Backend Backend work not usually visible to players. P-0-High High priority, crash/breaking. MC-1.21.1 and removed Status-Triage A Triage Member should take a look at this labels Dec 4, 2024
@Rover656 Rover656 moved this from To triage to Ready in Ender IO Bugs Dec 4, 2024
@Xefyr0
Copy link
Author

Xefyr0 commented Dec 4, 2024

Something else that I should mention is that this issue is mostly limited to when a large amount of Capacitor Banks are in a single blob.
Strategically removing 1/2 of the banks in the 10x10x10 cube to drastically reduce the number of adjacent Capacitor Banks to 10 per unit brings the mspt back down to 4.

This contrasts with the 8x8x8 cube, which has roughly the same amount of capacitor banks, but is many times more impactful on performance.

Image

@Rover656 Rover656 linked a pull request Dec 13, 2024 that will close this issue
7 tasks
@Rover656 Rover656 linked a pull request Dec 13, 2024 that will close this issue
7 tasks
@Rover656 Rover656 moved this from Ready to In progress in Ender IO Bugs Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Backend Backend work not usually visible to players. MC-1.20.1 MC-1.21.1 P-0-High High priority, crash/breaking. Type-Bug There is a problem.
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants