:refactor: comment가 null인 Review는 조회하지 않도록 개선

Team-Blitz-Steady · Nov 22, 2023 · ed2b92a · ed2b92a
1 parent 25fd202
commit ed2b92a
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/main/java/dev/steady/review/infrastructure/ReviewQueryRepositoryImpl.java b/src/main/java/dev/steady/review/infrastructure/ReviewQueryRepositoryImpl.java
@@ -29,6 +29,7 @@ public List<String> getPublicCommentsByRevieweeUser(User user) {
         return jpaQueryFactory.select(review.comment)
                 .from(review)
                 .where(revieweeEqualsUser(user),
+                        review.comment.isNotNull(),
                         isPublic())
                 .orderBy(review.createdAt.desc())
                 .fetch();
@@ -37,9 +38,10 @@ public List<String> getPublicCommentsByRevieweeUser(User user) {
     @Override
     public List<ReviewsBySteadyResponse> getAllReviewsByRevieweeUser(User user) {
         return jpaQueryFactory.selectFrom(steady)
-                .leftJoin(review)
+                .innerJoin(review)
                 .on(steady.id.eq(review.steady.id))
-                .where(revieweeEqualsUser(user))
+                .where(revieweeEqualsUser(user),
+                        review.comment.isNotNull())
                 .orderBy(steady.finishedAt.desc())
                 .transform(groupBy(steady.id)
                         .list(Projections.constructor(