음악신청 조회시 자신이 좋아요 눌렀는지 유무 확인 #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MusicLikeServiceImpl.kt Co-authored-by: �Hope Kim <[email protected]>
Co-authored-by: �Hope Kim <[email protected]>
…usicLikeException.kt Co-authored-by: �Hope Kim <[email protected]>
…into 413-music-like-cancel-function # Conflicts: # src/main/kotlin/com/dotori/v2/domain/music/service/impl/ToggleMusicLikeServiceImpl.kt
…ction 음악 좋아요, 좋아요 삭제 기능
refactor :: imageUpload refactor
…mber-of-likes 좋아요, 좋아요 취소 시 현재 좋아요 수 반환
…t-number-of-likes Music 좋아요, 좋아요 취소 시 현재 좋아요 수 반환 안됨
…rver-V2 into 415-feat/music-rank-query
415 음악 랭킹 조회 api + 최신순 조회 like count 반환값 추가
Music 조회할 때 좋아요 유무 반환
update :: find music rank desc
ta2ye0n
requested review from
uuuuuuuk,
esperar,
KimGyeongsuuu,
m2ri1 and
yena5511
as code owners
esperar
reviewed
Sep 23, 2024
Comment on lines
48
to
50
| return musicLikeRepository.findByMemberIdAndMusicId(member.id, music.id) != null | ||
| } | ||
|
|
There was a problem hiding this comment.
여기부분 exists query 활용으로 바꿔주면 좋을 것 같아요!
esperar
approved these changes
Sep 23, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 개요
음악 신청순으로 조회시 본인이 좋아요 눌렀는지 유무 확인하는 필드를 추가했습니다
likeCount 캐시 문제 해결
📃 작업내용