Skip to content

Commit

Permalink
Fix 'symbolic_shield' advancement
Browse files Browse the repository at this point in the history
  • Loading branch information
ExDrill committed Aug 17, 2024
1 parent 6a32345 commit 5b404b7
Show file tree
Hide file tree
Showing 8 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// 1.21.1 2024-08-16T20:34:12.7535516 Guarding/Recipes
// 1.21.1 2024-08-16T20:51:07.7816574 Guarding/Recipes
f70b28cfd7b66008f81013bdd758e0c0ce54f548 data\guarding\advancement\recipes\tools\netherite_shield_smithing.json
182ad57f9bbeae0ef3ddb8cc541e25d291c1b667 data\guarding\recipe\netherite_shield_smithing.json
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// 1.21.1 2024-08-16T20:34:12.7535516 Guarding/Tags for minecraft:item
// 1.21.1 2024-08-16T20:51:07.7816574 Guarding/Tags for minecraft:item
de3c2592e324c222e3837ca75443bf5c42169e42 data\c\tags\item\tools\shield.json
2bcf0095e15e46fd0f6db6b9c4264c1169924451 data\guarding\tags\item\enchantable\shield.json
de3c2592e324c222e3837ca75443bf5c42169e42 data\minecraft\tags\item\enchantable\durability.json
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// 1.21.1 2024-08-16T20:34:12.7515507 Guarding/Advancements
6147e8d55e73d046e534172b57848937fd866aa2 data\guarding\advancement\story\symbolic_shield.json
// 1.21.1 2024-08-16T20:51:07.7796567 Guarding/Advancements
c02f1391ae47d7daa386edd6e2dbd41159b81914 data\guarding\advancement\story\symbolic_shield.json
dcb1bb929a15a25de2cd7429b7365f4a0b486a9d data\guarding\advancement\story\parry_this_you_casual.json
f2491848a40cdd4e61bdf82b5377a1693a66656a data\guarding\advancement\nether\on_guard.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
// 1.21.1 2024-08-16T20:34:12.7525514 Guarding/Dynamic Registries
// 1.21.1 2024-08-16T20:51:07.7806571 Guarding/Dynamic Registries
b8c6a7c04eabbe6db6ec48e535a945fd6346f828 data\guarding\enchantment\barbed.json
f513c9cb427129a70fea51f5cf2e97b2b848fbb9 data\guarding\enchantment\pummeling.json
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// 1.21.1 2024-08-16T20:34:12.7545519 Guarding/Tags for minecraft:enchantment
// 1.21.1 2024-08-16T20:51:07.7826572 Guarding/Tags for minecraft:enchantment
b258520fde11b3dc5bfecd1066da0f153df95484 data\minecraft\tags\enchantment\non_treasure.json
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// 1.21.1 2024-08-16T20:34:12.7545519 Guarding/Tags for minecraft:damage_type
// 1.21.1 2024-08-16T20:51:07.7826572 Guarding/Tags for minecraft:damage_type
f0ee1b9e1756201a9687a340a234b144be639d5e data\guarding\tags\damage_type\no_parry.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"conditions": {
"recipe_id": "minecraft:shield_decoration"
},
"trigger": "minecraft:crafter_recipe_crafted"
"trigger": "minecraft:recipe_crafted"
}
},
"display": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ private static void createSymbolicShield(HolderLookup.Provider lookup, Consumer<
AdvancementType.TASK,
true, true, false
);
advancement.addCriterion("decorate_shield", RecipeCraftedTrigger.TriggerInstance.crafterCraftedItem(ResourceLocation.withDefaultNamespace("shield_decoration")));
advancement.addCriterion("decorate_shield", RecipeCraftedTrigger.TriggerInstance.craftedItem(ResourceLocation.withDefaultNamespace("shield_decoration")));
advancement.parent(new AdvancementHolder(ResourceLocation.withDefaultNamespace("story/deflect_arrow"), null));
advancement.requirements(AdvancementRequirements.Strategy.AND);
advancement.save(exporter, SYMBOLIC_SHIELD.toString());
Expand Down

0 comments on commit 5b404b7

Please sign in to comment.