[MT-1504] Refresh and Reload improvements #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d RemotePublishSettings Fix RemoteCommands issues: - load url remote commands successfully after others have been previously added - refresh remote commands on interval - fix cache usage for remote commands - use etag instead of if-not-modified-since - safely extract fileName from url - always use commandId to access different remote commands instead of a mix of commandId and fileName Add a way for PublishSettings to be retrieved from local bundle Fix ResourceRetriever to accept all 20x responses as correct
…hecks in ResourceRefresher Move the should refresh entirely inside of the resource refresher Move the logging in the delegate calls instead
Fix sessionbaseURL with double // Add delegate call for cached/bundle settings Fix old tests
…off for cooldown Interval
… bundle for url remote commands Create an internal bundle option just for tests
Make sure that when errorCooldown is nil the normal refreshInterval is used
Remove MockRemoteCommandsDiskStorage
jameskeith
approved these changes
Apr 29, 2024
Enricoza
added a commit
that referenced
this pull request
May 2, 2024
* Make remote commands accept local paths with and without extension definition * Use constants for dle and tiq urls * Share a ResourceRetriever and ResourceRefresher for RemoteCommands and RemotePublishSettings Fix RemoteCommands issues: - load url remote commands successfully after others have been previously added - refresh remote commands on interval - fix cache usage for remote commands - use etag instead of if-not-modified-since - safely extract fileName from url - always use commandId to access different remote commands instead of a mix of commandId and fileName Fix ResourceRetriever to accept all 20x responses as correct * Add retry mechanism for ResourceRetriever and improve shouldRefresh checks in ResourceRefresher Move the should refresh entirely inside of the resource refresher Move the logging in the delegate calls instead * Fix refresh logic with wrong conditions Add delegate call for cached/bundle settings Fix old tests * Remove resource retriever forced refresh when not cached and add backoff for cooldown Interval * Make condition clearer for when to use local bundle RemoteCommand config * Use commandId instead of filename for remote commands cache and asset bundle for url remote commands Create an internal bundle option just for tests * Reorganize files * Improve VisitorServiceRetriever urlSession and completion calls * Simplify Resource Refresher error handling * Improve Collect urlSession and Completion calls * Test ResourceRetriever with a new MockURLSession * Fix ResourceRefresher Cooldown logic and add some tests * Add ResourceRefresher tests and create ErrorCooldown utility to help with tests * Improve and test ErrorCooldown Make sure that when errorCooldown is nil the normal refreshInterval is used * Remove settings from bundle option * Fix old remote commands manager tests * Fix collect completion * Fix remaining old tests for remote commands Remove MockRemoteCommandsDiskStorage * Add RemoteCommands tests for bundle and refreshes * Fix TagManagement flaky tests * Reload webview after session updates * Add some documentation and improve isFileCached * Fix comment spacing * Fix inAppPurchase tests * Improve readability of dynamicTrack and fix mock webview in tests * Try to use M1 mac on CICD * Fix wrong macos specification * Reset ErrorCooldown counter on non-errors * Make publishsettings tests more reliable * Ignore 304 errors from ResourceRetriever in ResourceRefresher's ErrorCooldown * Try to make Autotracking UI tests more reliable on slow CICD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.