Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ids_list_geographies() and ids_list_counterparts() functions #21

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

christophscheuch
Copy link
Collaborator

The current PR provides first versions for the geographies and counterparts tables. Both will be updated to their final versions once we include the geography micropackage in #18. For instance, geography_name is not standardized yet and some fields in counterparts_type are wrong because counterparts_name is not aligned with other names in World Bank API responses.

@chriscarrollsmith
Copy link
Contributor

chriscarrollsmith commented Oct 21, 2024 via email

@christophscheuch christophscheuch requested review from t-emery and removed request for AnieIfeh October 21, 2024 12:21
Copy link
Contributor

@t-emery t-emery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like a good first iteration to me.

@christophscheuch christophscheuch merged commit ecc30e6 into main Oct 21, 2024
6 checks passed
@christophscheuch christophscheuch deleted the 11-create-ids_list_geographies-function branch October 21, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ids_list_counterparts() function Create ids_list_geographies() function
3 participants