Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ids_list_series() and ids_list_series_topics() functions #16

Merged
merged 10 commits into from
Oct 20, 2024

Conversation

christophscheuch
Copy link
Collaborator

@christophscheuch christophscheuch commented Oct 18, 2024

I use internal data that is stored in sysdata.rda because it is not automatically exported to the user, but it can be called via ids_list_series(). This approach keeps the namespace tidy.

I followed the instructions here and here.

I discovered that sometime the character values that come from WDI have leading empty spaces. I'll fix that in the wbwdi package: tidy-intelligence/r-wbwdi#16

@christophscheuch christophscheuch added the enhancement New feature or request label Oct 18, 2024
@christophscheuch christophscheuch self-assigned this Oct 18, 2024
@christophscheuch christophscheuch linked an issue Oct 18, 2024 that may be closed by this pull request
@christophscheuch christophscheuch linked an issue Oct 18, 2024 that may be closed by this pull request
@christophscheuch christophscheuch changed the title Add ids_list_series() function Add ids_list_series() and ids_list_series_topics() functions Oct 18, 2024
Copy link
Contributor

@chriscarrollsmith chriscarrollsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look at the comments; a couple spots may need attention

R/ids_list_series.R Show resolved Hide resolved
data-raw/wbids_data.R Show resolved Hide resolved
@christophscheuch christophscheuch merged commit fedda54 into main Oct 20, 2024
6 checks passed
@christophscheuch christophscheuch deleted the 14-create-ids_list_series-function branch October 20, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create ids_list_series_topics() function Create ids_list_series() function
2 participants