+111
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog status: ✔️ |
Убрано насильное изменение интента игрока на Граб чтобы поднять пачку стикеров путём добавления переменной forceGrab что обходит проверку на граб в функции attack_hand
Теперь цветок поднимается из вазы через MouseDrop, а не через attack_hand. Уменьшило лабиринты кода, упростило всё гораздо.
KIBORG04
reviewed
Nov 26, 2024
Comment on lines
+135
to
+144
| /obj/item/vase/MouseDrop(mob/user) | ||
| . = ..() | ||
| if(flower && user == usr && !usr.incapacitated() && Adjacent(usr)) | ||
| if(ishuman(user)) | ||
| user.put_in_hands(flower) | ||
| else | ||
| flower.forceMove(get_turf(src)) | ||
| flower = null | ||
| update_icon() | ||
| return |
There was a problem hiding this comment.
Suggested change
| /obj/item/vase/MouseDrop(mob/user) | |
| . = ..() | |
| if(flower && user == usr && !usr.incapacitated() && Adjacent(usr)) | |
| if(ishuman(user)) | |
| user.put_in_hands(flower) | |
| else | |
| flower.forceMove(get_turf(src)) | |
| flower = null | |
| update_icon() | |
| return | |
| /obj/item/vase/MouseDrop_T(mob/user) | |
| ..() | |
| user.put_in_hands(flower) | |
| flower = null | |
| update_icon() |
Как и в ПРе на стикеры
There was a problem hiding this comment.
А куда дел проверку на flower?
KIBORG04
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание изменений
Добавил 10 ваз для цветов. Изменил спрайты подсолнуха, мака, колокольчика и м'тира чтобы влезали в вазы.
Почему и что этот ПР улучшит
Начинаю парад атомизации своих непропущенных ПРов.
Авторство
AndreyGysev
Чеинжлог
🆑 AndreyGysev