Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation tests #525

Merged
merged 23 commits into from
Dec 3, 2023
Merged

Conversation

aadito123
Copy link
Member

Form validation was merged a while back, so am just merging the test cases for it. Having issues with the tests for Vue.

Copy link

codesandbox-ci bot commented Nov 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@crutchcorn crutchcorn marked this pull request as ready for review December 3, 2023 12:16
@codecov-commenter
Copy link

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (c2f9957) 84.55% compared to head (dc92576) 91.65%.
Report is 58 commits behind head on main.

Files Patch % Lines
packages/form-core/src/FormApi.ts 89.55% 12 Missing and 2 partials ⚠️
packages/form-core/src/FieldApi.ts 92.85% 5 Missing ⚠️
packages/form-core/src/utils.ts 90.00% 2 Missing ⚠️
packages/react-form/src/useField.tsx 71.42% 2 Missing ⚠️
packages/solid-form/src/createField.tsx 96.55% 1 Missing ⚠️
packages/solid-form/src/createForm.tsx 92.30% 1 Missing ⚠️
packages/solid-form/src/formContext.ts 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #525      +/-   ##
==========================================
+ Coverage   84.55%   91.65%   +7.09%     
==========================================
  Files           9       21      +12     
  Lines         395      671     +276     
  Branches      109      184      +75     
==========================================
+ Hits          334      615     +281     
+ Misses         52       49       -3     
+ Partials        9        7       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit 8e90e4f into TanStack:main Dec 3, 2023
6 checks passed
@aadito123 aadito123 deleted the form-validation-tests branch December 22, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants