Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update store packages to match dedicated repo #427

Merged
merged 3 commits into from
Sep 2, 2023
Merged

Conversation

crutchcorn
Copy link
Member

Recently, we migrated @tanstack/store packages to a dedicated repo. When we did so, we shifted some of the behavior (to fix bugs in the package, shown through testing).

This PR:

  • Bumps the packages
  • Fixes newly broken behavior caused by the packages
  • Fixes a bug causing meta to be undefined in specific instances
  • Wrote tests to validate we won't regress on the aforementioned bug
  • Fixes tests that break on faster computers (like mine, evidently) caused by a short async time

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 2, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

Patch coverage is 100.00% of modified lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Files Changed Coverage
packages/form-core/src/FieldApi.ts 100.00%
packages/form-core/src/FormApi.ts 100.00%

📢 Thoughts on this report? Let us know!.

@crutchcorn crutchcorn merged commit 4cb1225 into main Sep 2, 2023
5 checks passed
@crutchcorn crutchcorn deleted the update-stores branch September 2, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants