fix: maximum depth exceeded should no longer occur on validation #408
+4
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running validation, there were some errors about maximum depth being exceeded. I fixed this by moving the validation check out of the stores'
onUpdate
and into thesetValue
function itself. It's not perfect, but I think this might honestly just be the way to go to sidestep this issue.At very least it solves the issue in the short term so we can keep writing tests and stabilizing the API
Closes #406