Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maximum depth exceeded should no longer occur on validation #408

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

crutchcorn
Copy link
Member

When running validation, there were some errors about maximum depth being exceeded. I fixed this by moving the validation check out of the stores' onUpdate and into the setValue function itself. It's not perfect, but I think this might honestly just be the way to go to sidestep this issue.

At very least it solves the issue in the short term so we can keep writing tests and stabilizing the API

Closes #406

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@77594a6). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #408   +/-   ##
=======================================
  Coverage        ?   57.41%           
=======================================
  Files           ?        7           
  Lines           ?      371           
  Branches        ?       90           
=======================================
  Hits            ?      213           
  Misses          ?      125           
  Partials        ?       33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit 0b5c94d into main Aug 29, 2023
4 of 5 checks passed
@crutchcorn crutchcorn deleted the fix-maximum-depth-exceeded branch August 29, 2023 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded when validation occurs
2 participants