Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor FormApi bugs and add initial form API tests #404

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Fix minor FormApi bugs and add initial form API tests #404

merged 6 commits into from
Aug 28, 2023

Conversation

crutchcorn
Copy link
Member

@crutchcorn crutchcorn commented Aug 28, 2023

This PR:

  • Fixes formApi.update to behave as I would expect it to
  • Fixes typings for pushFieldValue and insertFieldValue helpers
  • Prevents throwing an error on swapFieldValues
  • Adds initial tests for form API
  • Fixes formApi.reset to include form values

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 28, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@fdf5758). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #404   +/-   ##
=======================================
  Coverage        ?   74.52%           
=======================================
  Files           ?        6           
  Lines           ?      212           
  Branches        ?       40           
=======================================
  Hits            ?      158           
  Misses          ?       48           
  Partials        ?        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn changed the title Fix formApi.update and add initial form API tests Fix minor FormApi bugs and add initial form API tests Aug 28, 2023
@tannerlinsley tannerlinsley merged commit 25237e4 into TanStack:main Aug 28, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants