Fix loading of local settings.

[olmari]

In drxf/settings.py move importing of local settings last thing that is done, this way any/all custom settings gets priority as they're loaded last.

Fixes: #460

Signed-off-by: Sami Olmari [email protected]

[tswfi]

In my testing I don't see any difference on where the settings_local is loaded.

1. uncomment "ACCOUNT_IBAN": (ACCOUNT_IBAN, "IBAN of the association's bank account"), in CONSTANCE_CONFIG in settings.py
2. add ACCOUNT_IBAN = "ABC123" in settings_local.py (the default value in settings.py is "FI12 3456 789"
3. run ./manage.py shell_plus
4. in the shell run

from constance import config
print(config.ACCOUNT_IBAN)

and it prints out ABC123

But what I do see is that Constance has added an object for the setting even if I have never saved anything into it...

Constance.objects.get(key='ACCOUNT_IBAN').value

Looks like constance initializes its objects when the key is queried for the first time. It will take the default value configured at that point in time and then keeps it in the db.

[olmari]

That would conceptually match why local settings loading as last thing would make it also go...

Does generally things know local settings has priority? Or how else they know other than loading local settings in settings.py as last thing "overriding" anything set prior? Tho goes too deep into code for my knowledge anyways, kinda, sorta.

[braaar]

I think in order for this to function as I originally intended it we need to load settings from settings_local.py both before setting up constance and afterwards.

If you don't define a constance config in your local settings, you probably want your local settings to be loaded into the defaults that are defined in the constance config section here in settings.py.

Feels a bit clunky, but that's kinda how it has to be when the constance config reads from settings/settings_local.

I'm not very well versed in python or django, so the ordering may be moot.

[braaar]

Un-delete these lines and the PR will work as intended. Perhaps leave a comment like so:

settings_local is loaded so that the constance config will receive defaults from settings_local.

[braaar]

Could this work?

Suggested change

	# Load non-default settings from settings_local.py if it exists
	try:
	from .settings_local import * # noqa
	except ImportError:
	pass
	# Load constance config from settings_local.py if it exists
	try:
	from .settings_local import CONSTANCE_BACKEND, CONSTANCE_CONFIG # noqa
	except ImportError:
	pass

[braaar]

Just to clarify: Here is the sequence of operations we need:

1. Load regular settings from settings.py
2. Load regular settings from settings_local.py
3. Consume the settings from settings.py and settings_local.py in the constance config.
4. (if constance config is set in settings_local.py) load the settings_local constance config, which should consume values from settings and setting_local just like the original constance config

Local settings should always override, therefore we need to override the constance config in the end, if applicable