Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parse_xml_v4_file.py #1

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

stefantrapp
Copy link

Bugfix for ipcr classification

Bugfix for ipcr classification
I believe this is the desires behavior
@stefantrapp
Copy link
Author

Keep publication_info attributes, do not overwrite with application_info. Just append the application_type.

@stefantrapp stefantrapp closed this Aug 3, 2022
@stefantrapp stefantrapp reopened this Aug 3, 2022
@stefantrapp
Copy link
Author

Please check if proposal correct.

@TamerKhraisha
Copy link
Owner

Hi @stefantrapp
Thank you for the PR. Sorry for replying late, I have been busy with work. I will get back to you with a review in the coming days.
Best
Tamer

@stefantrapp
Copy link
Author

No problem. Looking forward to your review.
Stefan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants