Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: preview panel + main window fixes and optimizations #700

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CyanVoxel
Copy link
Member

@CyanVoxel CyanVoxel commented Jan 13, 2025

Summary

This PR provides a few fixes and optimizations regarding refreshing the preview panel and resetting the state of the main window UI as a whole when closing or switching libraries:

  • The media file preview for the preview panel now only updates when necessary
    • Before this would always update when information about the entry was modified, including when tags were added or even simply edited. Now operations such as adding tags no longer cause image thumbnails to re-render or for videos to restart.
  • The preview panel is now cleared when closing or switching libraries
  • The search bar is now cleared when closing or switching libraries
  • The scrollbar position is now reset when closing or switching libraries
  • The filter state, notably the page number, is now reset when switching libraries

@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Type: UI/UX User interface and/or user experience Priority: Medium An issue that shouldn't be be saved for last labels Jan 13, 2025
@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Jan 13, 2025
@CyanVoxel CyanVoxel changed the title fix: only update file preview when necessary fix: preview panel + main window state fixes and optimizations Jan 13, 2025
@CyanVoxel CyanVoxel marked this pull request as ready for review January 13, 2025 23:20
@CyanVoxel CyanVoxel added the Type: QoL A quality of life (QoL) enhancement or suggestion label Jan 13, 2025
@CyanVoxel CyanVoxel changed the title fix: preview panel + main window state fixes and optimizations fix: preview panel + main window fixes and optimizations Jan 13, 2025
@CyanVoxel CyanVoxel added the Status: Review Needed A review of this is needed label Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium An issue that shouldn't be be saved for last Status: Review Needed A review of this is needed Type: Bug Something isn't working as intended Type: QoL A quality of life (QoL) enhancement or suggestion Type: UI/UX User interface and/or user experience
Projects
Status: 🏓 Ready for Review
Development

Successfully merging this pull request may close these issues.

1 participant