fix: preview panel aliases not staying up to date with database #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added shortcuts for adding and removing aliases and updated the alias ui to always show remove button and not cover alias aliases use flowlayout wrote test for buildTagPanel removeSelectedAlias parent tags now use flowlayout in build tag panel moved buttons for adding aliases and parents to be at the end of the flowLayout
Aliases table
Added display names to tags
…ay names work as expected, adding aliases outputs them in order
…top alias will select the next on down
Aliases UI
…ed or an alias was removed
…atabase after edits where made using the tagDatabasePanel
DandyDev01
force-pushed
the
fix_preview_panel_edit_aliases
branch
from
4099415 to
3a3470f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the preview panel not staying up to date with what is actually in the tag database.
when a tag was edited using the tagDatabasePanel those changes would not be reflected in the previewPanel and when a tag was edited from the previewPanel those changes where not saved to the database.