Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update pytest workflow to 24.04 #639

Merged
merged 7 commits into from
Dec 12, 2024
Merged

chore: update pytest workflow to 24.04 #639

merged 7 commits into from
Dec 12, 2024

Conversation

python357-1
Copy link
Collaborator

@python357-1 python357-1 commented Dec 12, 2024 •
edited
Loading

This PR updates the pytest workflow to Ubuntu 24.04.

@python357-1 python357-1 changed the title fix: try fixing pytest workflow chore: update pytest workflow to 24.04 Dec 12, 2024
@CyanVoxel CyanVoxel added Type: Bug Something isn't working as intended Priority: Critical An issue that requires immediate attention Type: CI Continuous Integration / workflows labels Dec 12, 2024
@python357-1
Copy link
Collaborator Author

@CyanVoxel it appears the only thing stopping pytest from working on ubuntu 24.04 is apt-update not being run, but it also doesn't seem like apt-update takes too long right now. In the future it might be a problem, but for now this fixes the pytest workflow and updates it to 24.04.

@CyanVoxel
Copy link
Member

@CyanVoxel it appears the only thing stopping pytest from working on ubuntu 24.04 is apt-update not being run, but it also doesn't seem like apt-update takes too long right now. In the future it might be a problem, but for now this fixes the pytest workflow and updates it to 24.04.

Thank you for the fix! We can monitor the run times as we go - a slow workflow is better than a broken workflow...

@CyanVoxel CyanVoxel merged commit a519c9a into TagStudioDev:main Dec 12, 2024
5 checks passed
DandyDev01 pushed a commit to DandyDev01/TagStudio that referenced this pull request Dec 13, 2024
@python357-1 @DandyDev01
chore: update pytest workflow to 24.04 (TagStudioDev#639)
0f29ab2 
* fix: try fixing pytest workflow

* chore: update pytest workflow to 24.04

* fix: fix libglx package name

* fix: try a different package

* fix: try apt-update first

* Revert "fix: try apt-update first"

This reverts commit 34c04f9.

* Reapply "fix: try apt-update first"

This reverts commit 775bc26.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Priority: Critical An issue that requires immediate attention Type: Bug Something isn't working as intended Type: CI Continuous Integration / workflows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@python357-1 @CyanVoxel