feat(ui): show filenames in thumbnail grid (Closes #85) #633
Conversation
CyanVoxel
added
Type: QoL
CyanVoxel
changed the title
tagstudio/src/qt/ts_qt.py
Outdated
| @@ -551,6 +568,10 @@ def toggle_libs_list(self, value: bool): | |||
| self.preview_panel.libs_flow_container.hide() | |||
| self.preview_panel.update() | |||
|
|
|||
| def toggle_grid_filenames(self, value: bool): | |||
There was a problem hiding this comment.
This doesn't "toggle" it "sets"; it should probably not be called toggle_grid_filenames
| def set_filename(self, filename: Path | str | None): | ||
| self.file_label.setText(str(filename)) | ||
|
|
||
| def toggle_filename(self, value: bool): |
There was a problem hiding this comment.
Same here as with the other method; Doesn't toggle and should therefore probably not be called such
There was a problem hiding this comment.
Are there intentional changes to this? If not should probably not merge this for fear of overwriting other intentional changes (Note: Maybe we should add this file to the .gitignore so it doesn't get accidentally included in commits?)
There was a problem hiding this comment.
Shoot, I didn't realize something happened to this file when committing (nor what) - and since it's part of a test that we can change I don't think we can get away with adding it to the .gitignore...
There was a problem hiding this comment.
maybe we could add something to the test harness that automatically reverts any changes to it when cleaning up, unless it had already been changed during init of the harness?
(not sure about the details; reverting changes should be easy, but checking whether it has been changed, no idea)
There was a problem hiding this comment.
Further note: There is a tool called sqldiff made by SQLite that checks two sqlite files for differences, maybe that could be used.
It only checks whether data in the tables has changed, while git would also report metadata changing. So if sqldiff finds no differences but git does it could be reset?
There was a problem hiding this comment.
Having the tests clean it up could work as a temporary solution or as a good solution for tests that require modifying a fixture database, however this database should not be being modified here and signals that there's a deeper issue.
We also went in depth with sqldiff, sqlite cli, git text diffs, even a hex editor yesterday and narrowed down the problem a bit. It seems to be the internal file change counter value being updated, and I've opened up a dedicated issue for it here: #644
| open_on_start_action.triggered.connect( | ||
| lambda checked: self.settings.setValue(SettingItems.START_LOAD_LAST, checked) | ||
| ) | ||
| file_menu.addAction(open_on_start_action) |
There was a problem hiding this comment.
The "Open Library on Start" option exists twice, once in View and once in File, and (un)checking one of them doesn't update the visual state of the other
The incorrect placements and names of these actions were getting in my way when adding the new action, so I went ahead and moved them to more accurate places, both in the code and in the menus themselves. |
This comment was marked as outdated.
This comment was marked as outdated.
Maybe reference that in the PR description / title, but sounds good |
I got this error yesterday on Windows as well, but it should've been fixed by 901ec7c? 👀 |
This is what I was referring to in the description with "I've also organized some of the existing menu options to make more sense, notably removing the "Window" menu", but maybe I could've been more clear about it |
This PR adds the ability display an entry's filename underneath its thumbnail in the grid view. This feature can be toggled on/off through the View -> "Show Filenames in Grid" menu option. I've also organized some of the existing menu options to make more sense, notably removing the "Window" menu.