Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and Fixes: Type Hints, Import Issues, and Code Formatting in UI code base #605

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactor and Fixes: Type Hints, Import Issues, and Code Formatting in UI code base #605

wants to merge 4 commits into from

Conversation

VasigaranAndAngel
Copy link
Collaborator

  • Refactored code to address type hint issues across multiple files.
  • Fixed import issues.
  • Resolved mypy and pytest errors.
  • Formatted with ruff.
  • Removal of few unnecessary lambdas.
  • Removal of home_ui.py, home.ui files.

@CyanVoxel CyanVoxel added Type: Refactor Code that needs to be restructured or cleaned up Priority: Low Doesn't require immediate attention Priority: Medium An issue that shouldn't be be saved for last Status: Review Needed A review of this is needed labels Nov 28, 2024
Computerdores
Computerdores reviewed Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@Computerdores Computerdores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments, all in all a lot of very nice refactoring though!

tagstudio/src/core/library/alchemy/library.py Show resolved Hide resolved
tagstudio/src/core/enums.py Outdated Show resolved Hide resolved
tagstudio/src/qt/helpers/file_opener.py Outdated Show resolved Hide resolved
tagstudio/src/qt/ts_qt.py Outdated Show resolved Hide resolved
tagstudio/src/qt/ts_qt.py Outdated Show resolved Hide resolved
tagstudio/src/qt/ts_qt.py Outdated Show resolved Hide resolved
tagstudio/src/qt/widgets/landing.py Show resolved Hide resolved
tagstudio/src/qt/widgets/thumb_renderer.py Outdated Show resolved Hide resolved
@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Nov 30, 2024
@VasigaranAndAngel
Refactor and Fixes: Type Hints, Import Issues, and Code Formatting
33b80b4 
- Refactored code to address type hint issues across multiple files.
- Fixed import issues.
- Resolved `mypy` and `pytest` errors.
- Formatted with ruff.
- Removal of few unnecessary lambdas.
- Removal of `home_ui.py`, `home.ui`

refactor: in main_window.py, removed 'Qt User Interface Compiler' warning and unwanted functions.
@VasigaranAndAngel
addressing request: changed filepath.as_posix() to str(filepath)
4eca516
@VasigaranAndAngel
fix: type hint fixes
e9d8912
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Computerdores Computerdores Computerdores left review comments

Assignees
No one assigned
Labels
Priority: Low Doesn't require immediate attention Priority: Medium An issue that shouldn't be be saved for last Type: Refactor Code that needs to be restructured or cleaned up
Projects
TagStudio Development
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VasigaranAndAngel @Computerdores @CyanVoxel