Fixed dialog windows tiling like main windows on tiling window managers. #464
+17
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I could not find in the documentation a list of what files are for dialog windows or anything along those lines, so I searched for instances of `self.setWindowModality` and as far as I'm seeing, it looks like that's all of them? In any case, all I did was add `self.setWindowFlags(Qt.Dialog)` to the init functions of every modal I found that calls setWindowModality, the files affected are: - add_field.py - file_extension.py - fix_dupes.py - fix_unlinked.py - folders_to_tags.py - mirror_entities.py - panel.py - progress.py Do let me know if I missed any or if some of these shouldn't be changed. This fix has not been tested on Wayland yet, but based on the assumption that Qt behaves the same on both display servers, it should work the same, as this is a very basic feature that both display servers should have. This fix is for [issue TagStudioDev#392](TagStudioDev#392)
3 tasks
CyanVoxel
added
Type: Bug
|
|
|
I am genuinely out of words about that, the program worked just fine on my end with Qt.Dialog and it didn't seem to print any warnings or anything different from otherwise. Whatever though, inheriting QDialog instead of QWidget seems to work fine as well, at least I hope it does. |
|
@ChloeZamorano can you please fix the failing pipeline? |
CyanVoxel
added
Status: Changes Requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not find in the documentation a list of what files are for dialog windows or anything along those lines, so I searched for instances of
self.setWindowModalityand as far as I'm seeing, it looks like that's all of them? In any case, all I did was addself.setWindowFlags(Qt.Dialog)to the init functions of every modal I found that calls setWindowModality, the files affected are:Do let me know if I missed any or if some of these shouldn't be changed, as I'm not familiar with this code base or this style of making GUIs.
This fix has not been tested on Wayland yet, but based on the assumption that Qt behaves the same on both display servers, it should work the same, as this is a very basic feature that both display servers should have.
This fix is for issue #392
For any discussions or comments, use my Discord (chloevz) if a quick reply is desired, as I don't tend to check Github daily.