Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show 'Close Library' if your in a library #462

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

CarterPillow
Copy link
Contributor

This is my first commit like ever on anything I know I made a lot of changes but I don't think this should have any effect outside of just only showing the close button when inside a library!

@Computerdores
Copy link
Contributor

I would suggest also hiding the "Refresh Directories", "Save Library" and "Save Library Backup" Buttons

@CarterPillow
Copy link
Contributor Author

I honestly did not even think of that but this hides all the buttons in the "files" menu that do not have any effect until you open a library I will look to see if there is anything else that might benefit from being hidden til you open a library.

…lying actions have any effect outside of a library
@CyanVoxel CyanVoxel added Type: UI/UX User interface and/or user experience Status: Review Needed A review of this is needed labels Sep 6, 2024
@eivl
Copy link
Collaborator

eivl commented Sep 7, 2024

Before opening a library
image

After
image

@CyanVoxel CyanVoxel removed the Status: Review Needed A review of this is needed label Sep 7, 2024
@CyanVoxel
Copy link
Member

A better way to approach this in my opinion would be to simply disable the menu options instead of removing them entirely, for example how the Edit menu handles this:
image

This way the options don't change locations making them more difficult to find based on the state of the library, plus the user is made aware of all options whether they're presently available or not.

@CarterPillow
Copy link
Contributor Author

Before Opening a Library
image image

After
image image

I looked at how the items were disabled in the version you showed (Alpha 9.4.0) and decided to add the "update_clipboard_actions" function over. Not the code from it since none of that is added yet just the function its self. This means that all the buttons will be enabled at first but since its the same function the ones that need to be disabled will be checked then disabled in the same code so its not a problem.

@CarterPillow
Copy link
Contributor Author

I woke up to a lot of merges and this no longer working so ill have a look at what broke it and fix this pr lol

@CyanVoxel CyanVoxel added this to the Alpha v9.5 (Post-SQL) milestone Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: UI/UX User interface and/or user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants