Test project by Sergey K. #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys!
Here is my take on this test project.
The solution uses awesome Flow library that was created specifically for such tasks - concurrently processing data streams.
You may notice I don't use database at all. Yeah... I've read about database requirement kind of late 😅 and I think this solution is good enough. But if you'll insist on it, I can add database support: should be as easy as changing
File.stream!withRepo.stream!and adding some boilerplate code.P.S. I've also took liberty of rewriting test data generation to Elixir and make project structure more Elixir-ish in general. If you'd like to use it later I can make it a separate PR.