-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ee): implement user authentication api #912
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darknight
commented
Nov 28, 2023
wsxiaoys
reviewed
Nov 29, 2023
wsxiaoys
reviewed
Nov 29, 2023
wsxiaoys
reviewed
Nov 29, 2023
wsxiaoys
reviewed
Nov 29, 2023
darknight
changed the title
feat(ee): implement user authentication and authorization
feat(ee): implement user authentication
Nov 29, 2023
wsxiaoys
reviewed
Nov 30, 2023
darknight
force-pushed
the
i805-user-registration
branch
from
November 30, 2023 04:36
56e4894
to
d82ec72
Compare
wsxiaoys
reviewed
Nov 30, 2023
wsxiaoys
reviewed
Nov 30, 2023
wsxiaoys
approved these changes
Dec 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for being patient on this PR, LGTM
wsxiaoys
changed the title
feat(ee): implement user authentication
feat(ee): implement user authentication api
Dec 1, 2023
This was referenced Dec 2, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For closing #805
Changes include:
The
refreshToken
implementation has not been finalized, so I do plan to raise separate PR for it.resetRegistrationToken
, onlyadmin
is allowed to execute itThere are some implementations need to be discussed, comment inline.