feat: Add OpenCL support #661
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsxiaoys
requested changes
Oct 29, 2023
wsxiaoys
requested changes
Oct 29, 2023
contrib/opencl/Dockerfile
Outdated
| @@ -0,0 +1,47 @@ | |||
| FROM rust:latest as build | |||
There was a problem hiding this comment.
Suggested change
| FROM rust:latest as build | |
| FROM ubuntu:23.04 as build |
Since you're not using rust from rust:latest anyway
|
Please fix formatting based on https://github.com/TabbyML/tabby/actions/runs/6685996496/job/18164937864?pr=661 |
|
@itlackey Hey, did you drop this? I might want to take a shot at it. Are there any issues with the current implementation? The comments indicate it was almost ready for merging. |
Might consider using vulkan backend, see https://tabby.tabbyml.com/blog/2024/05/01/vulkan-support/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature would enable running Tabby locally on Intel GPUs such as Arc (and potentially integrated GPUs).