Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TYPO3 Exception 1303237468 #287

Closed
wants to merge 2 commits into from

Conversation

franzholz
Copy link
Contributor

The extension raises an exception when no system extension reactions has been activated.

Copy link
Contributor

@garvinhicking garvinhicking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I think though the proper fix is to add a dependnecy on sys_reactions. The composer.json already lists this, so it would need to be added to ext_emconf too!

@franzholz
Copy link
Contributor Author

I think it is a bad idea to add dependencies on other extensions. The user should decide what he wants to use.

@linawolf
Copy link
Member

I agree with @garvinhicking here. the dependencies from the composer.json and the ext_emconf.php should be the same

linawolf added a commit that referenced this pull request Aug 31, 2024
This also prevents TYPO3 Exception 1303237468 #287

Releases: main, 12.4
linawolf added a commit that referenced this pull request Aug 31, 2024
This also prevents TYPO3 Exception 1303237468 #287

Releases: main, 12.4
@linawolf
Copy link
Member

Thanks a lot for bringing this issue to our notice. It has been resolved with #290

@linawolf linawolf closed this Aug 31, 2024
linawolf added a commit that referenced this pull request Aug 31, 2024
This also prevents TYPO3 Exception 1303237468 #287

Releases: main, 12.4
linawolf added a commit that referenced this pull request Aug 31, 2024
This also prevents TYPO3 Exception 1303237468 #287

Releases: main, 12.4
@franzholz
Copy link
Contributor Author

This is a bad solution, because you cannot copy-paste the example and use it for your own extension. Do not forget that the examples from here are used as example code snippets in the TYPO3 documentation.

@linawolf
Copy link
Member

linawolf commented Aug 31, 2024

"Thank you for your feedback, Franz. I understand your concern about making examples as adaptable and flexible as possible for developers who want to use them in their own extensions.

However, I agree with Garvin hat ensuring consistency between composer.json and ext_emconf.php is crucial for maintaining reliable extension behavior. When an extension relies on a specific system extension like EXT:reactions, declaring that dependency in both files is important for preventing unexpected issues, especially for less experienced developers who might not realize the dependency is required.

Regarding your point about copy-pasting examples, I see where you're coming from. While the examples provided in the documentation should indeed be easy to adapt, they also need to reflect best practices to ensure stability and functionality. We want to encourage developers to be mindful of dependencies when integrating example code into their own projects.

If you have ideas on how we can make it clearer that the example is just one way to implement this while still emphasizing the importance of declaring dependencies, we’d love to hear them. Our goal is to provide examples that are both practical and instructive, helping developers avoid common pitfalls.

Thank you for continuing to engage in this discussion. Your input is valuable as we work to create documentation that serves the entire TYPO3 community."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants