Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Remove rector for version 12.4 #285

Merged
merged 2 commits into from
Aug 26, 2024
Merged

[BUGFIX] Remove rector for version 12.4 #285

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d7e687
[BUGFIX] Remove rector for version 12.4
linawolf Aug 26, 2024
7afaefe
[BUGFIX] Fix CGL
linawolf Aug 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,6 @@ jobs:
- name: CGL
run: Build/Scripts/runTests.sh -n -p ${{ env.php }} -s cgl

- name: Rector
run: Build/Scripts/runTests.sh -n -p ${{ env.php }} -s rector

- name: PHPStan
run: Build/Scripts/runTests.sh -p ${{ env.php }} -s phpstan

Expand Down
1 change: 0 additions & 1 deletion Classes/Controller/ModuleController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@
*/
class ModuleController extends ActionController
{

private int $pageUid;
/** @var array<string, mixed> */
private array $exampleConfig;
Expand Down