[TASK] Switch to use ssch/typo3-rector ^2.3 #261
Conversation
linawolf
changed the title
|
The php-cs-fixer is strangely configured. Usually it is supposed to clear up such things as the FQN. Should I try to improve the cs-fixer within this PR or in a follow up? |
As you know, I prefer focusing on one topic ;-) |
So we will deal with improved CS fixing in another PR. Please concentrate on Rector here |
|
I think I was able to clear it up. It is not the cs-fixer who is responsible but rector. I enabled Now. |
There was a problem hiding this comment.
I wonder, if rector / typo3-rector works with TYPO3 v13.1? There is a conflict between nikic/php-parser: v13.1 uses v5, whereas rector uses v4 (and not compatible yet with v5). So, I assume, TYPO3 v13.0.1 is used on dev-locally and on CI.
Currently, on my extensions, I am deactivating/removing rector because of this conflict (no recent TYPO3 v13 installable).
|
There was just a discussion about this https://typo3.slack.com/archives/C019R5LAA6A/p1714647866307099 I hit the problem in the blog-extension. It might be a good idea to use the current suggestion of kevin appelt, it is just I am not sure how to do that |
Sadly, rector does not provide a phar, so we cannot use phive for that. So, one solution may be like outlined in the link above. |
Apply Rector for TYPO3 v13 Fix cgl Releases: main
Levels can be raised step by step in follow-ups We need to get rid of the outdated XClass extension, but don't have a replacement yet, that is why I left it in for now. run with Build/Scripts/runTests.sh -s phpstan Generate baseline with Build/Scripts/runTests.sh -s phpstanBaseline
Apply Rector for TYPO3 v13
Fix cgl
Releases: main