Skip to content

Commit

Permalink
[TASK] Streamline Build/Scripts/runTests.sh (#264)
Browse files Browse the repository at this point in the history
This change modifies the `Build/Scripts/runTests.sh`
execution wrapper to be in line with current TYPO3
core implementation.

This contains following tasks:

* Modify `Build/Scripts/runTests.sh`:
    * `-b <container-binary>` switch to determine which
      container binary should be used.
    * Remove the usage of `docker-compose.yml` file and
      usage by replacing container execution call with
      docker or podman binary calls.
    * Include `bash trap` logic for container/network
      cleanup on abort signals.
    * Keep core `xdebug` flag ability, albeit not used
      currently due to not having tests included.
* Remove `-s composerValidate` and `-s composerNormalize`
  from suit execution, because it can directly dispatched
  using the new `-s composer` dispatcher command. This
  reduces adoption of direct commands for the future.
* Refactor suit command execution without docker-compose.
* Remove `Build/testing-docker/docker-compose.yml` due
  to being obsolete now.
* Add composer related temporary files to `.gitignore`
  and `.gitattributes`.
* Add documentation rendering and test rendering to the
  `runTests.sh`.
  • Loading branch information
sbuerk authored May 3, 2024
1 parent 5631098 commit fb0a56c
Show file tree
Hide file tree
Showing 5 changed files with 244 additions and 219 deletions.
3 changes: 3 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
/.* export-ignore
/Build export-ignore
/rector.php export-ignore
/composer.lock export-ignore
/composer.json.testing export-ignore
/composer.json.orig export-ignore
4 changes: 1 addition & 3 deletions .github/workflows/test-documentation.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,4 @@ jobs:

- name: Test if the documentation will render without warnings
run: |
mkdir -p Documentation-GENERATED-temp \
&& docker run --rm --pull always -v $(pwd):/project \
ghcr.io/typo3-documentation/render-guides:latest --config=Documentation --no-progress --fail-on-log
Build/Scripts/runTests.sh -s testRenderDocumentation
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
.idea
.Build
composer.lock
/composer.lock
/composer.json.testing
/composer.json.orig
*GENERATED*
.ddev
Loading

0 comments on commit fb0a56c

Please sign in to comment.