Skip to content

Commit

Permalink
[TASK] Mark properties as private in AdminModuleController (#283)
Browse files Browse the repository at this point in the history
As the class is defined as final, it does not make sense to set the properties as
protected as this class cannot be extended.

Releases: main, 12.4
  • Loading branch information
brotkrueml authored and froemken committed Aug 25, 2024
1 parent ba9b384 commit afa147f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Classes/Controller/AdminModuleController.php
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
final class AdminModuleController
{
public function __construct(
protected readonly ModuleTemplateFactory $moduleTemplateFactory,
protected readonly IconFactory $iconFactory,
private readonly ModuleTemplateFactory $moduleTemplateFactory,
private readonly IconFactory $iconFactory,
// ...
) {}

Expand Down

0 comments on commit afa147f

Please sign in to comment.