Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for fieldControl -> rendertype #1204

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

simonschaufi
Copy link
Contributor

No description provided.

@simonschaufi
Copy link
Contributor Author

How can I create a link to another documentation? I need some support here please

@simonschaufi
Copy link
Contributor Author

Why are the tests failing? I don't think this has something to do with my PR

@garvinhicking
Copy link
Contributor

Why are the tests failing? I don't think this has something to do with my PR

Yes, should be unrelated. @linawolf Do you know the reasons? Content-blocks and v14 compatibility?

How can I create a link to another documentation? I need some support here please

On every headline when you hover you see an anchor icon. Clicking on it reveals a modal popup that shows you how to link to that. You pick the "RST" variant. HTH :)

@linawolf
Copy link
Member

yep, my fault, I ll take care of it sometime this week, very busy today

@linawolf
Copy link
Member

@simonschaufi please rebase, tests should be green then

@simonschaufi
Copy link
Contributor Author

I've noticed that the sorting depends on if the key is with uppercase or lowercase written. That is a bit strange. That is why I added the uppercase key as well to have a consistent sorting. Otherwise the Path would be the last entry.

@@ -88,13 +118,34 @@
button to open an element browser. It is enabled by default if rendering a
group element.

.. confval:: renderType
:name: group-fieldControl-elementBrowser-renderType
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this need to be all lowercase or not?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name needs to be lowercase

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that really true? I have found others to be in the same format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants