DirectionalIR: added treatment of IRs with full head rotation range #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (like BBC Salford) to phiMin, phiMax and torsoAzimuth calculation. Also changed torsoAzimuth to be in [0, 360[ instead of ]0, 360].
…itsTorso_unsetIfFullHeadRange
…nd reducing data removal frequency
|
Unfortunately, I'm no longer able to test anything under Matlab. So, I guess I'm no longer a good reviewer for Two!Ears ;) Regarding your changes, I have no objections, but @fietew might be the better person for detailed feedback. |
|
According to github, you also changed the binaries, @ivo--t. Was this intended? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added treatment of IRs with full head rotation range (like BBC Salford) to phiMin, phiMax and torsoAzimuth calculation. Otherwise torsoAzimuth goes NaN, which doesn't allow for proper usage of binsim.
Also changed torsoAzimuth to be in [0, 360[ instead of ]0, 360].