This repository has been archived by the owner on Jan 7, 2025. It is now read-only.
Make fixes for Stackdriver v2 #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors included in a logrus.Entry are not formatted correctly. This is caused by sirupsen/logrus#137
|
Also rewrote the tests. |
|
Would be nice to see this merged. |
|
I'm not able to merge this as I've left TV4 a while ago. Not sure if this is maintained. @jsageryd? Maybe better to create a fork? |
|
looks good |
orsinium
reviewed
Jan 7, 2021
| module github.com/icco/logrus-stackdriver-formatter | ||
|
|
||
| require ( | ||
| github.com/TV4/logrus-stackdriver-formatter v0.1.0 |
There was a problem hiding this comment.
AFAIK, the project shouldn't be a dependency of itself.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges in changes that are in a few forks, and also fixes #5 and #6.