Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Implement in-app updates #1312

Closed
wants to merge 1 commit into from
Closed

Conversation

jacqueline8711
Copy link
Member

Issue

Fixes #1296

Not sure about whether to put it in MainActivity, StartupActivity or BaseActivity (at least the onResume to cover all entry points)
Not tested yet.

Screenshot

TODO when testing

https://developer.android.com/guide/app-bundle/in-app-updates

@kordianbruck
Copy link
Member

So BaseActivity does not seem to fit as we want to be very predictable when such notifications happen. I'd also think that MainActivity is too late. Ideally we would show the update prompt, before any other requests/refreshes are started. It might be harder to implement it during startup, but it would save us some headaches. I'd also just do the immediate upgrades, so that people get the newest version right away.

Thoughts?

@thellmund
Copy link
Contributor

thellmund commented Aug 15, 2019

What’s the state of this? @jacqueline8711’s implementation looks good to me (maybe encapsulate in a custom class) and I’m not sure I understand @kordianbruck’s concerns.

@jacqueline8711
Copy link
Member Author

@thellmund I think my main problem was that I didn't know how to test if the code actually works since I didn't know how to trigger the in-app update / choose if the flexible or immediate update should be shown

@Bentipa
Copy link
Member

Bentipa commented Jul 5, 2022

What is the current state of this PR? @jacqueline8711

@CommanderStorm CommanderStorm deleted the jacqueline/force-update branch July 20, 2022 19:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add force update option
4 participants