Skip to content

Commit

Permalink
Incorporate review comments by parcollet
Browse files Browse the repository at this point in the history
  • Loading branch information
Wentzell committed Feb 1, 2022
1 parent 824922e commit d771fc2
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions c++/itertools/itertools.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -169,14 +169,14 @@ namespace itertools {

/********************* Product Iterator ********************/

template <typename sentinel_tuple_t, typename... It>
struct prod_iter : iterator_facade<prod_iter<sentinel_tuple_t, It...>, std::tuple<typename std::iterator_traits<It>::value_type...>> {
template <typename TupleSentinel, typename... It>
struct prod_iter : iterator_facade<prod_iter<TupleSentinel, It...>, std::tuple<typename std::iterator_traits<It>::value_type...>> {

std::tuple<It...> its_begin;
sentinel_tuple_t its_end;
TupleSentinel its_end;
std::tuple<It...> its = its_begin;

prod_iter(std::tuple<It...> its_begin, sentinel_tuple_t its_end) : its_begin(std::move(its_begin)), its_end(std::move(its_end)) {}
prod_iter(std::tuple<It...> its_begin, TupleSentinel its_end) : its_begin(std::move(its_begin)), its_end(std::move(its_end)) {}

template <int N>
void _increment() {
Expand Down

0 comments on commit d771fc2

Please sign in to comment.