512 improve configuration of the knowledge engine #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also group the configuration keys in a dedicated *Config class.
We no longer use environment variables directly, but we do that through MicroProfile Config implementation. Values are automatically overridden by users using environment variables or Java system properties. We can determine whether a value was overridden by checking whether the ConfigValue#getSourceOrdinal() of a configuration value is > 100.
At a later stage we also need to update the documentation in the ./docs/ folder.
Does not work yet.
They work correctly now.
Not every configuration option could be tested because the message dispatcher is initialized only once per JVM.
512-improve-configuration-of-the-knowledge-engine
Sophietje
reviewed
Dec 18, 2024
smart-connector/src/test/java/eu/knowledge/engine/smartconnector/misc/ConfigurationTest.java
Show resolved
Hide resolved
...or/src/test/java/eu/knowledge/engine/smartconnector/misc/WireMockFirstConfigurationTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using MicroProfile Config version 3.1 specification and the SmallRye Config implementation of this spec. This allows us to change to a different implementation in the future. Replaced all environment variable based configuration with the new framework. Also moved all default values from code to a
META-INF/microprofile-config.propertiesconfiguration file and the config keys to theSmartConnectorConfigclass. I usedConfigValue#getSourceOrdinal()to determine whether the user has overridden the default values, because distributed mode is only started when they set thekd.url.Things that could/should still be done: