Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a more useful ReasonerPlan toString. #534

Merged
merged 7 commits into from
Sep 30, 2024
Merged

Conversation

bnouwt
Copy link
Collaborator

@bnouwt bnouwt commented Aug 30, 2024

Using the graphviz visualization.

Also fixed a but which confused the includeMetaKIs() and the isMeta() methods.

bnouwt added 3 commits August 30, 2024 17:02
Using the graphviz visualization.
We need to think about how to solve this, because if we change it to
isMeta() (which it should be), it runs out of memory because the
MockedKnowledgeBase (and KnowledgeNetwork) are not meta, but we do not
want to run those in normal mode (apparently).
@bnouwt
Copy link
Collaborator Author

bnouwt commented Sep 20, 2024

The problem is a TimeoutException being thrown during a test. In this test it takes too long to initialize a particular Smart Connector, so the timeout is thrown (because communication with other SCs is slow). There are two things to look into:

  • Why does it take so longer, while previously it did not. Probably, because we introduced the new levels and configuration for them which influenced when certain levels got used by the reasoner.
  • The timeout exception should be dealt with correctly, while currently it is not I think.

Not sure yet if it fixes the long announce times that break the build on
github.
With many SCs they started to take a long time and started to exceed
some thresholds.
- MessageRouterImpl now logs TimeoutExceptions explicitly.
- RuleStore printGraphViz(...) now does not print duplicate edges.
- performance improvement reasoner plan creation.
@bnouwt bnouwt merged commit f910f99 into master Sep 30, 2024
2 checks passed
@bnouwt bnouwt deleted the add-reasonerplan-tostring branch September 30, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant