463 when an other ker is unavailable the current ker should not log a lot of completionexceptions caused by contacting it anyway #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Done: - remove unnecessary exceptions from log - make logging smarter/more comprihensible - introduce different timeouts
Done: - remove unnecessary exceptions from log - make logging smarter/more comprihensible - introduce different timeouts
…ould-not-log-a-lot-of-completionexceptions-caused-by-contacting-it-anyway' of [email protected]:TNO/knowledge-engine.git into 463-when-an-other-ker-is-unavailable-the-current-ker-should-not-log-a-lot-of-completionexceptions-caused-by-contacting-it-anyway
Done: - introduced configurable timeout for how long to wait for other KBs - when a KER becomes unavailable, its SCs are no longer taken into account when exchanging data. - when querying the KD, we now also manage unavailable KERs to make sure when they come available again, they are taken into account again. - included the new configuration ENVIRONMENT VARAIBLE in the readme.
Issue was: - when we first start our communication, other KERs do not know our KBs yet when we send them a message to announce ourselves. - when we first let other KERs know, our communication is not yet started when we receive (and want to reply) to messages from other KERs. The current version is that we do not immediately send a message to another KER when it contacts us, but we wait for it to announce itself. However, not sure whether this actually works in all scenario's, so we need to test this further or think about it further.
Also: - remove some unnecessary http configuration.
…urrent-ker-should-not-log-a-lot-of-completionexceptions-caused-by-contacting-it-anyway
Updated version, but remember to update it to 1.2.4 when releasing.
It now waits with populating and informing other KERs until the communication is ready. Also: - fixed/improved unit tests
bnouwt
deleted the
463-when-an-other-ker-is-unavailable-the-current-ker-should-not-log-a-lot-of-completionexceptions-caused-by-contacting-it-anyway
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.