Initial offering of DAG factory for task parsers #21
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of how the DAG factory pattern can be used for task parsers. Right now it's quite simplistic: a
TaskParser
key is added to the study'ssettings.yml
, which lists tasks and the appropriate command. As of now this means it does not support any dynamic arguments to whatever command is being issued - we can discuss if this is an important feature or not.So for example,
SPN20_settings.yml
needs to contain the additional key:Studies can specify multiple task parsers, e.g. for OPT:
I still need to write tests for this implementation but thought I would post for feedback beforehand since it's been a long time coming!