Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial offering of DAG factory for task parsers #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

benselby
Copy link

@benselby benselby commented Dec 8, 2021

This is an example of how the DAG factory pattern can be used for task parsers. Right now it's quite simplistic: a TaskParser key is added to the study's settings.yml, which lists tasks and the appropriate command. As of now this means it does not support any dynamic arguments to whatever command is being issued - we can discuss if this is an important feature or not.

So for example, SPN20_settings.yml needs to contain the additional key:

TaskParser:
    EA: dm_parse_ea.py SPN20 --debug --regex "*MR*EMP*"

Studies can specify multiple task parsers, e.g. for OPT:

TaskParser:
        FACES: dm_parse_faces.py OPT
        FAKE: echo "FAKE OUT!"

I still need to write tests for this implementation but thought I would post for feedback beforehand since it's been a long time coming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant