Issue #231: Added notifications when plugins are force activated #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
creativecoder
changed the title
|
@creativecoder Hi Grant, sorry for not responding to this PR earlier. A lot has changed in TGMPA since you made this PR, but I kind of like the idea and would be open to adding this for the next release. Would you be willing to submit a new PR against the current develop branch ? |
|
Yes, I can rebase and submit a new pull request--I'll try to get to that later this week. Thanks, Grant |
|
@creativecoder Awesome! Thank you. I look forward to it. |
|
Hi @creativecoder Just wondering if you've had a chance to look at this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added this with the goal of providing feedback to users that indicates why plugins are being automatically reactivated.
Implemented by adding a new method, for possibly extending this to work on forced deactivation, at some point in the future.