Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Continuous Integration using Github Actions #223

Merged
merged 12 commits into from
Apr 29, 2024
Merged

Conversation

peace-maker
Copy link
Contributor

@peace-maker peace-maker commented Jul 11, 2023

This builds the frontend and backend using Node.js 16, 18, 19, and 20 and checks if the database migrations apply on a fresh database. It verifies the generated graphql bindings are up-to-date too.

To allow to verify database migrations, I've added a DB_MIGRATE_ONLY environment variable, which causes the api to exit after processing the migrations.

In a separate step it runs linting steps as eslint and prettier to catch style problems.

We could run docker compose build as well just to verify the docker setup works? I didn't go for this in the first place, since you don't have yarn in the frontend container anymore to verify the codegen.

@XeR
Copy link
Contributor

XeR commented Jul 17, 2023

Thanks for the PR ! I'd like to get #217 merged first.
@JJ-8 since you've worked on Github-specific yaml files, your feedback on this PR would be very valuable

@peace-maker
Copy link
Contributor Author

@XeR can you have a look again?

@XeR XeR requested a review from B-i-t-K November 28, 2023 13:02
@peace-maker
Copy link
Contributor Author

The changes have been updated for the recent v3 release.

@JJ-8 JJ-8 self-requested a review April 29, 2024 15:21
@JJ-8 JJ-8 merged commit c2e0638 into TFNS:main Apr 29, 2024
4 checks passed
@peace-maker peace-maker deleted the ci branch April 29, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants