Feat/ecs/bullet systems #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cavonstavant
requested changes
Oct 7, 2022
CMakeLists.txt
Outdated
Comment on lines
39
to
40
| if (CLIENT_COMPILATION_MODE) | ||
| add_compile_definitions(CLIENT_COMPILATION_MODE) |
There was a problem hiding this comment.
For future use
Use target_compile_definition() in order to set CLIENT_MODE only for the client target
There was a problem hiding this comment.
why not add_compile_definitions only on the client's cmakelists ? @Cavonstavant
There was a problem hiding this comment.
demo will probably be deleted once the game is successfully networked
There was a problem hiding this comment.
@aurelenc Yes ofc. We can use target_compile_definitions() to add a def. to specific target
…AAAAA/RTYPE into feat/ecs/bullet-systems
This was
linked to
issues
Oct 11, 2022
This was
unlinked from
issues
Oct 11, 2022
|
Good progress |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add shoot systems