Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking the latest PETSc revision. #190

Merged
merged 1 commit into from
Jul 27, 2021
Merged

Conversation

jeff-cohere
Copy link
Collaborator

@jeff-cohere jeff-cohere commented Jul 26, 2021

To clarify our dependencies, we note the tested PETSc revision in our README, and refer to the appropriate Docker image tag in our workflow files. In particular, we no longer use the latest tag, which is uninformative.

The only code change needed to adopt this new rev is the location of the khash header files.

In support of #188

To clarify our dependencies, we note the tested PETSc revision in our README,
and refer to the appropriate Docker image tag in our workflow files.

The only code change needed to adopt this new rev is the location of the
khash header files.
@jeff-cohere jeff-cohere self-assigned this Jul 26, 2021
@jeff-cohere jeff-cohere added the petsc Changes to PETSc version label Jul 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #190 (b57d34c) into master (5b0dfec) will not change coverage.
The diff coverage is n/a.

❗ Current head b57d34c differs from pull request most recent head 3552ecf. Consider uploading reports for the commit 3552ecf to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   67.73%   67.73%           
=======================================
  Files           7        7           
  Lines        1221     1221           
=======================================
  Hits          827      827           
  Misses        394      394           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b0dfec...3552ecf. Read the comment docs.

@jeff-cohere jeff-cohere merged commit b74fafd into master Jul 27, 2021
@jeff-cohere jeff-cohere deleted the jeff-cohere/bump-petsc-rev branch July 27, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
petsc Changes to PETSc version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants