Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

新增 dialog #110

Merged
merged 22 commits into from
Sep 25, 2024
Merged

新增 dialog #110

merged 22 commits into from
Sep 25, 2024

Conversation

novlan1
Copy link
Contributor

@novlan1 novlan1 commented Jul 23, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

新增 dialog

📝 更新日志

  • feat(dialog): add dialog

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@novlan1 novlan1 changed the title Feature/dialog 新增 dialog Jul 23, 2024
Copy link

github-actions bot commented Jul 23, 2024

完成

@duenyang
Copy link
Contributor

image 此处交互和其它组件库不一致 https://tdesign.tencent.com/react/components/dialog#%E6%A8%A1%E6%80%81%E4%B8%8E%E9%9D%9E%E6%A8%A1%E6%80%81%E7%B1%BB%E5%AF%B9%E8%AF%9D%E6%A1%86

@duenyang
Copy link
Contributor

image 和其它组件库交互不一致

@duenyang
Copy link
Contributor

image

@duenyang
Copy link
Contributor

image

@duenyang
Copy link
Contributor

函数式调用没有实现
image

@novlan1
Copy link
Contributor Author

novlan1 commented Aug 28, 2024

image 和其它组件库交互不一致

哪里不一致了,这里不是有吗 @duenyang
其他的已经处理了

image

@duenyang
Copy link
Contributor

duenyang commented Aug 29, 2024

image 和其它组件库交互不一致

哪里不一致了,这里不是有吗 @duenyang 其他的已经处理了

image
2024-08-29.16.50.00.mov

选择超出屏幕-> 随意滑动-> 点击鼠标会移动到最下面 @novlan1

@duenyang
Copy link
Contributor

duenyang commented Aug 29, 2024

image @novlan1

src/dialog/dialog.tsx Outdated Show resolved Hide resolved
src/dialog/dialog.tsx Show resolved Hide resolved
@novlan1
Copy link
Contributor Author

novlan1 commented Sep 24, 2024

image @novlan1

image 和其它组件库交互不一致

哪里不一致了,这里不是有吗 @duenyang 其他的已经处理了
image

2024-08-29.16.50.00.mov
选择超出屏幕-> 随意滑动-> 点击鼠标会移动到最下面 @novlan1

done @duenyang

@novlan1
Copy link
Contributor Author

novlan1 commented Sep 24, 2024

image @novlan1

done

@duenyang duenyang merged commit 9827b40 into TDesignOteam:main Sep 25, 2024
5 checks passed
This was referenced Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants