Better version parsing.

TBXin · May 18, 2016 · d5bc048 · d5bc048
1 parent e601600
commit d5bc048
Showing 1 changed file with 23 additions and 2 deletions.
diff --git a/src/NFirmwareEditor/Managers/UpdatesManager.cs b/src/NFirmwareEditor/Managers/UpdatesManager.cs
@@ -1,4 +1,5 @@
 using System;
+using System.Globalization;
 using System.Threading;
 using JetBrains.Annotations;
 using NLog;
@@ -39,9 +40,29 @@ public ReleaseInfo CheckForUpdates()
 		{
 			s_logger.Info("Checking for updates...");
 			var latestRelease = GitHubApi.GetLatestRelease();
-			if (latestRelease == null || string.Equals(m_currentVersion, latestRelease.Tag) || latestRelease.Assets.Length == 0)
+			if (latestRelease == null || latestRelease.Assets.Length == 0)
 			{
-				s_logger.Info("No updates available.");
+				s_logger.Info("No updates found.");
+				return null;
+			}
+
+			float currentVersion;
+			float newVersion;
+
+			var v1 = float.TryParse(m_currentVersion, NumberStyles.Float, CultureInfo.InvariantCulture, out currentVersion);
+			var v2 = float.TryParse(latestRelease.Tag, NumberStyles.Float, CultureInfo.InvariantCulture, out newVersion);
+
+			if (v1 == false || v2 == false)
+			{
+				if (string.Equals(m_currentVersion, latestRelease.Tag))
+				{
+					s_logger.Info("Your are using latest version (string checking).");
+					return null;
+				}
+			}
+			else if (currentVersion >= newVersion)
+			{
+				s_logger.Info("Your are using latest version (float checking).");
 				return null;
 			}