Support did_dht_resolution in C #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresuribe87
requested review from
KendallWeihe,
nitro-neal,
shamilovtim,
diehuxx,
frankhinek and
leordev
as code owners
TBD Spec Test Vectors Report (web5-core-kt)
❌ Missing Vectors (15)These are test vectors without any test cases.
Automatically generated at: 2024-10-11T16:01:32.183Z |
TBD Spec Test Vectors Report (web5-rs)
❌ Missing Vectors (13)These are test vectors without any test cases.
Automatically generated at: 2024-10-11T15:58:11.360Z |
KendallWeihe
reviewed
Oct 9, 2024
| } else { | ||
| match unsafe { CStr::from_ptr(gateway_url).to_str() } { | ||
| Ok(s) => Some(s.to_string()), | ||
| Err(_) => return ptr::null_mut(), |
There was a problem hiding this comment.
at some point we should introduce better error handling over the C FFI, but it's not necessary at this moment
There was a problem hiding this comment.
Created #392 to track.
KendallWeihe
reviewed
Oct 9, 2024
KendallWeihe
reviewed
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Adds support for
did_dht_resolutionin a C ABI.Let me know if it's cool to include the tokio runtime
web5_clibrary that's being built by thebindcrecipe.Related Tickets & Documents
N/A - couldn't find any. I wanted to add this because I'm aiming to extend curl so that it can handle
didprotocols. This is critical in order to promote interop. Since curl is written in C, this is a simple first step to use the rust-core to power the curl fork I'll be working on.Mobile & Desktop Screenshots/Recordings
N/A
Added code snippets?
Added tests?
No tests? Add a note
The provided example code is the test itself. There is a README with the explanation.
Added to documentation?
No docs? Add a note
Added a README that explains how to run the given code.
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?