Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently sync interval stops if there is a failure, instead log failure and wait for the interval #958

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Oct 21, 2024

This PR fixes the issue where a sync interval would stop completely if any error occurred during sync.

This will now catch the error and log it, continuing to attempt sync the next interval.
Additionally, enqueueing operations for each DID/Remote will not wait for each one to complete sequentially and instead take advantage of Promise.allSettled. Which also will not fail if a single peer of the array fails and instead log the error.

Copy link

changeset-bot bot commented Oct 21, 2024

⚠️ No Changeset found

Latest commit: 8ccf9d2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 21, 2024

TBDocs Report

✅ No errors or warnings

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-10-21T22:10:30Z 27c2967

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.35%. Comparing base (5120f6f) to head (27c2967).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   93.35%   93.35%           
=======================================
  Files         118      118           
  Lines       33734    33747   +13     
  Branches     2740     2746    +6     
=======================================
+ Hits        31493    31506   +13     
  Misses       2200     2200           
  Partials       41       41           
Components Coverage Δ
agent 87.82% <100.00%> (+0.01%) ⬆️
api 99.61% <ø> (ø)
common 95.02% <ø> (ø)
credentials 94.95% <ø> (ø)
crypto 93.79% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.42% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.42% <ø> (ø)
user-agent 96.57% <ø> (ø)

@LiranCohen LiranCohen marked this pull request as ready for review October 21, 2024 22:09
@LiranCohen LiranCohen merged commit 7072331 into main Oct 21, 2024
35 checks passed
@LiranCohen LiranCohen deleted the lirancohen/sync-engine-error-log branch October 21, 2024 23:30
@github-actions github-actions bot mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants