Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

differentiate between Record creator and author #893

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

LiranCohen
Copy link
Member

@LiranCohen LiranCohen commented Sep 6, 2024

Add a property to the Record class that denotes the record's creator.

When the record is an initial write, the creator and author will return the same.

Created this issue to add query/filter for creator: TBD54566975/dwn-sdk-js#800

Copy link

changeset-bot bot commented Sep 6, 2024

🦋 Changeset detected

Latest commit: ddafa7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web5/api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 6, 2024

TBDocs Report

🛑 Errors: 0
⚠️ Warnings: 5

@web5/api

  • Project entry file: packages/api/src/index.ts

@web5/crypto

  • Project entry file: packages/crypto/src/index.ts
📄 File: ./packages/crypto/src/utils.ts
⚠️ extractor:typedoc:missing-docs: CryptoUtils (Variable) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomPin (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomUuid (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.randomBytes (Property) does not have any documentation.
⚠️ extractor:typedoc:missing-docs: CryptoUtils.__type.getJoseSignatureAlgorithmFromPublicKey (Property) does not have any documentation.

@web5/crypto-aws-kms

  • Project entry file: packages/crypto-aws-kms/src/index.ts

@web5/dids

  • Project entry file: packages/dids/src/index.ts

@web5/credentials

  • Project entry file: packages/credentials/src/index.ts

TBDocs Report Updated at 2024-09-06T23:05:41Z ddafa7e

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.44%. Comparing base (2ec2d21) to head (ddafa7e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #893   +/-   ##
=======================================
  Coverage   93.43%   93.44%           
=======================================
  Files         117      117           
  Lines       33301    33308    +7     
  Branches     2673     2675    +2     
=======================================
+ Hits        31116    31123    +7     
  Misses       2146     2146           
  Partials       39       39           
Components Coverage Δ
agent 87.43% <ø> (ø)
api 99.60% <100.00%> (+<0.01%) ⬆️
common 98.68% <ø> (ø)
credentials 94.95% <ø> (ø)
crypto 93.79% <ø> (ø)
dids 97.77% <ø> (ø)
identity-agent 96.42% <ø> (ø)
crypto-aws-kms 100.00% <ø> (ø)
proxy-agent 96.42% <ø> (ø)
user-agent 96.57% <ø> (ø)

csuwildcat
csuwildcat previously approved these changes Sep 6, 2024
thehenrytsai
thehenrytsai previously approved these changes Sep 6, 2024
@LiranCohen LiranCohen merged commit 43a5078 into main Sep 7, 2024
35 checks passed
@LiranCohen LiranCohen deleted the lirancohen/record-creator branch September 7, 2024 14:13
This was referenced Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants